Open
Conversation
This commit applies a number of general cleanup tasks across the codebase:
- Ran pre-commit hooks (isort, black, flake8) to enforce formatting and linting.
- Addressed flake8 findings:
- Removed unused imports in `titrate/upperlimits.py` and `titrate/validation.py`.
- Removed unused local variables in `titrate/upperlimits.py`.
- Removed debugging print statements from `plotting.py`, `upperlimits.py`, and `validation.py`.
- Fixed `CopyModelError` definition in `utils.py`.
- Verified usage of custom `kstest` in `statistics.py` (used in tests) and kept it.
- Made minor docstring and comment improvements in `upperlimits.py` and `utils.py`.
- Corrected a typo in a test function name in `test_validation.py` (test_AsmyptoticValidator -> test_AsymptoticValidator).
- Updated `examples/Analysis.ipynb`:
- Changed hardcoded absolute paths to relative paths for data files.
- Commented out loading of a J-factor map from a non-standard, developer-specific path and added a note for you.
- Removed a developer-specific markdown comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit applies a number of general cleanup tasks across the codebase:
titrate/upperlimits.pyandtitrate/validation.py.titrate/upperlimits.py.plotting.py,upperlimits.py, andvalidation.py.CopyModelErrordefinition inutils.py.kstestinstatistics.py(used in tests) and kept it.upperlimits.pyandutils.py.test_validation.py(test_AsmyptoticValidator -> test_AsymptoticValidator).examples/Analysis.ipynb: