Skip to content

Comments

Refactor: General codebase cleanup#31

Open
StFroese wants to merge 1 commit intomainfrom
cleanup/general-codebase-improvements
Open

Refactor: General codebase cleanup#31
StFroese wants to merge 1 commit intomainfrom
cleanup/general-codebase-improvements

Conversation

@StFroese
Copy link
Owner

This commit applies a number of general cleanup tasks across the codebase:

  • Ran pre-commit hooks (isort, black, flake8) to enforce formatting and linting.
  • Addressed flake8 findings:
    • Removed unused imports in titrate/upperlimits.py and titrate/validation.py.
    • Removed unused local variables in titrate/upperlimits.py.
  • Removed debugging print statements from plotting.py, upperlimits.py, and validation.py.
  • Fixed CopyModelError definition in utils.py.
  • Verified usage of custom kstest in statistics.py (used in tests) and kept it.
  • Made minor docstring and comment improvements in upperlimits.py and utils.py.
  • Corrected a typo in a test function name in test_validation.py (test_AsmyptoticValidator -> test_AsymptoticValidator).
  • Updated examples/Analysis.ipynb:
    • Changed hardcoded absolute paths to relative paths for data files.
    • Commented out loading of a J-factor map from a non-standard, developer-specific path and added a note for you.
    • Removed a developer-specific markdown comment.

This commit applies a number of general cleanup tasks across the codebase:

- Ran pre-commit hooks (isort, black, flake8) to enforce formatting and linting.
- Addressed flake8 findings:
    - Removed unused imports in `titrate/upperlimits.py` and `titrate/validation.py`.
    - Removed unused local variables in `titrate/upperlimits.py`.
- Removed debugging print statements from `plotting.py`, `upperlimits.py`, and `validation.py`.
- Fixed `CopyModelError` definition in `utils.py`.
- Verified usage of custom `kstest` in `statistics.py` (used in tests) and kept it.
- Made minor docstring and comment improvements in `upperlimits.py` and `utils.py`.
- Corrected a typo in a test function name in `test_validation.py` (test_AsmyptoticValidator -> test_AsymptoticValidator).
- Updated `examples/Analysis.ipynb`:
    - Changed hardcoded absolute paths to relative paths for data files.
    - Commented out loading of a J-factor map from a non-standard, developer-specific path and added a note for you.
    - Removed a developer-specific markdown comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant